Skip to content

fix(imputation): add missing CpGs from source in impute_from_standard #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcbal77 merged 1 commit into from
Dec 5, 2025
Merged

fix(imputation): add missing CpGs from source in impute_from_standard #187

marcbal77 merged 1 commit into from
Dec 5, 2025

Conversation

@marcbal77
Copy link
Member

@marcbal77 marcbal77 commented Dec 4, 2025 •
edited
Loading

PR accomplishes the following:
-impute_from_standard now adds missing CpG rows from cpg_source when cpgs_to_impute is provided

  • Uses pandas reindex to expand the DataFrame before filling

Fixes #86

sarudak
sarudak approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@sarudak sarudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcbal77 marcbal77 merged commit 5fd73d2 into bio-learn:master Dec 5, 2025
1 check passed
@marcbal77 marcbal77 deleted the fix/86-impute-missing-cpgs branch December 5, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarudak sarudak sarudak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

impute from standard doesn't impute (add) cpgs which are missing from the dataset

2 participants

@marcbal77 @sarudak